-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable candidate v3.1.1 #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marion <[email protected]>
DIG-1671: Adding date format to manifest
* add sample redcap files * restructure suggestion * mv sample files * update sample inputs links and info * Update README.md --------- Co-authored-by: Marion <[email protected]>
* add splitting script * minor refactoring
* fix deceased validation * change bools to single_vals * fix more cause_of_death validations * update test data, fix validations, update template/manifest
* numeric not availabe and schema template update * update default url * improve template generation, add not_available to missingness * update v3 template * methods for -99 mappng * update test template and test data * update script and moh_diffs * fix typo in validation * updated mapping functions doc
* Allows to be run as a stand alone. * pytest corrections for schema updates. * workflow installation works without the pip install -e. * Completed conversion to a module. Corrected imports throughout. Allow imports from CWD.
…idation to required fields (#86) * add warning for missing reference date (instead of error) * blank dodiag and update to latest schema * update test * fix specimen validation * only write warnings json if there are warnings * add warnings for unconditional required fields * add warning to validation file * update tests * cleanup --------- Co-authored-by: Javier Castillo-Arnemann <[email protected]> Co-authored-by: Javi <[email protected]>
DIG-1860: Move missing cases to validation file
Update documentation & remove dist files
daisieh
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick code scan, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cases_missing_data
from*_map.json
tovalidation_results.json