Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable candidate v3.1.1 #91

Merged
merged 82 commits into from
Nov 22, 2024
Merged

Stable candidate v3.1.1 #91

merged 82 commits into from
Nov 22, 2024

Conversation

yavyx
Copy link
Contributor

@yavyx yavyx commented Nov 22, 2024

  • Restored validation for unconditionally required fields
  • Added warning when a patient's date of diagnosis is missing
  • Moved patients list cases_missing_data from *_map.json to validation_results.json
  • Removed dist files
  • Improved package imports
  • Template diff git workflow fix

mshadbolt and others added 25 commits September 5, 2024 12:46
* add splitting script

* minor refactoring
* fix deceased validation

* change bools to single_vals

* fix more cause_of_death validations

* update test data, fix validations, update template/manifest
* numeric not availabe and schema template update

* update default url

* improve template generation, add not_available to missingness

* update v3 template

* methods for -99 mappng

* update test template and test data

* update script and moh_diffs

* fix typo in validation

* updated mapping functions doc
* Allows to be run as a stand alone.

* pytest corrections for schema updates.

* workflow installation works without the pip install -e.

* Completed conversion to a module. Corrected imports throughout.  Allow imports from CWD.
…idation to required fields (#86)

* add warning for missing reference date (instead of error)

* blank dodiag and update to latest schema

* update test

* fix specimen validation

* only write warnings json if there are warnings

* add warnings for unconditional required fields

* add warning to validation file

* update tests

* cleanup

---------

Co-authored-by: Javier Castillo-Arnemann <[email protected]>
Co-authored-by: Javi <[email protected]>
DIG-1860: Move missing cases to validation file
Update documentation & remove dist files
@yavyx yavyx requested review from daisieh and mshadbolt November 22, 2024 21:55
Copy link
Member

@daisieh daisieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick code scan, looks good to me.

@yavyx yavyx merged commit 17d6ea7 into stable Nov 22, 2024
2 checks passed
@yavyx yavyx deleted the stable-candidate-v3.1.1 branch November 22, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants